I've heard gamers more hardcore than I say that XBox Elite controllers are the hands-down best ones.
I think the SNES controller figured out 2D gaming just right, the 360 controller felt good for 3D gaming. The Dual Shock is the best of both worlds and I also think it benefits from just not changing too much for 20 years, so you only had to make slight adjustments with each new console whereas going from something like N64 to Gamecube to Wii was some wild bullshit.
Gun to my head, Dual Shock.